-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix public link share, default expiration behavior #34960
Conversation
Codecov Report
@@ Coverage Diff @@
## master #34960 +/- ##
============================================
- Coverage 65.38% 65.37% -0.01%
+ Complexity 18592 18588 -4
============================================
Files 1213 1213
Lines 70408 70401 -7
Branches 1295 1295
============================================
- Hits 46036 46027 -9
- Misses 23998 24000 +2
Partials 374 374
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #34960 +/- ##
============================================
- Coverage 65.38% 65.38% -0.01%
+ Complexity 18592 18588 -4
============================================
Files 1213 1213
Lines 70408 70400 -8
Branches 1295 1295
============================================
- Hits 46035 46028 -7
+ Misses 23999 23998 -1
Partials 374 374
Continue to review full report at Codecov.
|
183fbe5
to
4d500f6
Compare
4d500f6
to
3e0fe23
Compare
3e0fe23
to
75a49f9
Compare
@karakayasemi yeah, you could just fix the wrapping to have it go to the next line |
Yes, agreed, move it below, please. |
75a49f9
to
7683bef
Compare
"enforce expiration date" checkbox carried to newline by adding |
@karakayasemi please backport |
Description
"default link expiration" sub-entry location problem fixed. Now, it is under "Set expiration date".
Currently, when the expiration date enabled and not enforced, the default expiration date is set even though the user deleted it on share creation. With this PR, if the user removes the expiration date on share creation, no expiration date will be set as discussed in here: https://github.com/owncloud/enterprise/issues/3204#issuecomment-478657949
Related Issue
https://github.com/owncloud/enterprise/issues/3204
Motivation and Context
Fixing bugs.
How Has This Been Tested?
Unit tests are adjusted. Also, manually tested with following steps:
To test share creation behavior;
Types of changes
Checklist:
Open tasks: